Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize relevancy score instead of maximize #44

Open
CorneliusHsiao opened this issue Aug 21, 2023 · 0 comments
Open

Minimize relevancy score instead of maximize #44

CorneliusHsiao opened this issue Aug 21, 2023 · 0 comments

Comments

@CorneliusHsiao
Copy link

CorneliusHsiao commented Aug 21, 2023

Hi, thanks for the excellent work! I have a question regarding your implementation:

best_id = softmax[..., 0].argmin(dim=1) # rays x 2

And in your paper Sec.3.5 (Relevancy Score), you stated:

Intuitively, this score represents how much closer the rendered embedding is towards the query embedding compared to the canonical embeddings.

My understanding about your inline equation and code is:
you try to pick $\phi^i_{canon}$ that is closer to $\phi_{lang}$ compared to $\phi_{lang}$ from $\phi_{quer}$, because minimization over $i$ means maximization of similarity between $\phi^i_{canon}$ and $\phi_{lang}$.

My question is:
why is this minimization instead of maximization? I think we are looking for $\phi_{lang}$ that best matches $\phi_{quer}$ instead of $\phi^i_{canon}$, right? Is it because we want the embedding to fit to both $\phi_{quer}$ and $\phi^i_{canon}$ at the same time? From my experiment, I do see that results getting worse if I change min to max, but could you explain a little bit more please?

Much thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant