New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot connect to server after creating a new database #4

Open

alx-ppv opened this issue Aug 13, 2019 · 0 comments

alx-ppv commented Aug 13, 2019

Hi,
First, thank you for this extension. I am creating a similar one to delete databases, and your code is pretty helpful.

I noticed that when you create a new database, you cannot connect to the server again, and you need to restart ADS.
To reproduce:

Connect to server and create new database
Disconnect from the server
Connect again
Result: ADS keeps trying to connect

I think the issue is coming from https://github.com/kevcunnane/azuredatastudio-dmpwrapper/blob/6d89258c62343e89d15fb7c836912a3f6df3be67/src/index.ts#L38

When you call registerOnConnectionComplete, in overrides the previous function.

I couldn't find any documentation, so I don't know whether this is a bug in ADS, or another approach should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment