Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_imgs function missing #66

Open
nezza opened this issue Nov 5, 2021 · 4 comments
Open

load_imgs function missing #66

nezza opened this issue Nov 5, 2021 · 4 comments

Comments

@nezza
Copy link

nezza commented Nov 5, 2021

Hello,

The load_imgs function, used in 6ab288d, is missing from the codebase :)

Thanks for this awesome project!

@kevinhughes27
Copy link
Owner

Hmm indeed it is. Code review failure on my part there. I'll see if the author of that PR has it otherwise I'd recommend reverting that commit to get it working or trying to figure out what load_imgs is supposed to do.

@nezza
Copy link
Author

nezza commented Nov 5, 2021

Thanks for the fast response!

That's what I ended up doing for now, will see if I can figure out what it's supposed to do tomorrow

Cheers!

@kevinhughes27
Copy link
Owner

I would guess that it loads all the images for a given sample and probably returns them as a List that will get converted to numpy later. I didn't look at the fork from the PR. It is possible the code is on the fork and just wasn't merged over here.

@kevinhughes27
Copy link
Owner

🤞 #65 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants