Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: send intent extra arrays are not saved #1224

Closed
4 tasks
sudomain opened this issue Jun 8, 2024 · 2 comments
Closed
4 tasks

action: send intent extra arrays are not saved #1224

sudomain opened this issue Jun 8, 2024 · 2 comments
Assignees
Labels
bug Something isn't working duplicate

Comments

@sudomain
Copy link

sudomain commented Jun 8, 2024

**Developer TODO (don't remove)**

  • create new branch. put issue number at start of name if not a very quick fix.
  • write tests. put issue number in comment
  • update documentation
  • merge and delete branch (don't squash because want commit history to see why I made changes)

Discord message link/email recipient

Describe the bug
When using a send intent action containing an extra which is any of the array types (string, integer, boolean, etc.), the extra gets discarded when the user presses the checkmark. There seems to be some input validation going on for some of the extras such as boolean arrays and integer arrays.

To Reproduce
Steps to reproduce the behavior:

  1. Create a send intent action
  2. Add an extra of any of the array types
  3. Tap the checkmark/save button
  4. Open the action for editing and notice the array has been discarded

Upload a backup of your keymaps. Follow the guide here

Expected behavior
Array extras should be not be silently discarded.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: [e.g. OnePlus 6T] pixel 2
  • Android version: [e.g. Android 10] android 11

Additional context
Add any other context about the problem here.

@sudomain sudomain added the bug Something isn't working label Jun 8, 2024
@sds100
Copy link
Collaborator

sds100 commented Jun 12, 2024

I think I fixed this already in #1172 ? Can you check the latest testing build

@sudomain
Copy link
Author

Confirmed fixed in the testing build. Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate
Projects
None yet
Development

No branches or pull requests

2 participants