Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SET and GET node incorrectly detect input/output undefined. #123

Open
Trung0246 opened this issue Oct 23, 2024 · 3 comments
Open

SET and GET node incorrectly detect input/output undefined. #123

Trung0246 opened this issue Oct 23, 2024 · 3 comments

Comments

@Trung0246
Copy link

SET and GET node is heavily dependent on node load order, hence will throw alert if output is undefined, despite being the node connected to is valid and will load later then SET and GET.

if (link_info && node.graph && slotType == 1 && isChangeConnect) {

I've suggest to wrap entire check around setTimeout or maybe update SET/GET node after all nodes are loaded.

@kijai
Copy link
Owner

kijai commented Oct 26, 2024

Can you give an example where this would happen? Never experienced this kind of issue myself, is this about compatibility with other custom nodes?

@Shyryp
Copy link

Shyryp commented Nov 5, 2024

I think I started getting this problem too.
Moreover, it is completely incomprehensible to me and appears when I load a workflow from a json file.

Screenshot of the error:
error

I use Easy-Use cycles, could there be a problem with them?

Here is a screenshot of the cycle and the Set nodes used near them:
er2

The error I get, it is not clear which node it points to. But I assume that this is precisely because of the use of Easy Use in cycles. Perhaps it is the "Start_Index" node in my case, since after deleting it, the error stopped appearing after reopening the workflow.

@Shyryp
Copy link

Shyryp commented Nov 5, 2024

The problem can especially arise if Set was accidentally reconnected to a certain variable type (for example, INT), and then reconnected to an unknown *. In this case, Set continues to consider the input as INT, although on the Set node itself it is specified as *.

Example (look at the color of the line, it has become dark blue, which means INT - this leads to an error when opening a workflow in Comfyui):
er3

Of course, in this case, the Get nodes stop being defined as IMAGE and break the connection, and therefore it is not a problem to figure out the problem in this case.

HOWEVER! This problem can also randomly appear even if I do not change the Set and Get nodes in any way! That is, the problem can suddenly appear from unknown actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants