Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source map warnings? #71

Open
aendra-rininsland opened this issue Sep 21, 2021 · 2 comments · May be fixed by #74
Open

Source map warnings? #71

aendra-rininsland opened this issue Sep 21, 2021 · 2 comments · May be fixed by #74

Comments

@aendra-rininsland
Copy link

I keep getting sundry source map warnings in development, which might be part of the reason source maps are frequently wrong while developing. Any thoughts?

Screenshot 2021-09-21 at 17 30 52
@robinhouston
Copy link
Contributor

Interesting! I think all these are part of the SDK implementation, and the issue is that the files reference sourcemaps (which don’t exist).

The sourcemap for your code ought to be loadable via the SDK from http://localhost:1865/script.js.map

@aendra-rininsland
Copy link
Author

aendra-rininsland commented Oct 7, 2021 •
edited
Loading

@robinhouston Ahhh interesting!! My guess is your npm publish script isn't including those, probably a pretty simple PR.

Edit: Nope, your build process for the site/ files is removing the sourcemaps, or not outputting them. You'll need to fix the sdk_clean and sdk Makefile targets as well. See below PR.

aendra-rininsland added a commit to aendra-rininsland/flourish-sdk that referenced this issue Oct 7, 2021
@aendra-rininsland
Removes sourcemaps URLs from site/ files
2e82532 
Fixes kiln#71.
@aendra-rininsland aendra-rininsland linked a pull request Oct 7, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removes sourcemaps URLs from site/ files aendra-rininsland/flourish-sdk
2 participants
@robinhouston @aendra-rininsland