Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tox.ini: use --extend-ignore instead of --ignore #11

Open
geoffroy-noel-ddh opened this issue Mar 24, 2019 · 2 comments
Open

tox.ini: use --extend-ignore instead of --ignore #11

geoffroy-noel-ddh opened this issue Mar 24, 2019 · 2 comments

Comments

@geoffroy-noel-ddh
Copy link
Member

geoffroy-noel-ddh commented Mar 24, 2019 •
edited
Loading

We use 'ignore' in tox.ini. This flag completely replaces the default ignored warnings. And therefore re-enable some mutually exclusive warnings such as W503 and W504 (line break before/after operator) which were never intended to be applicable both at the same time.

See this thread for details:
https://gitlab.com/pycqa/flake8/issues/466

In our tox.ini could we change this
ignore = F405
to
extend-ignore = F405,W503
?
@brian-maher
Copy link
Contributor

I don't see why not. @jmiguelv any disinclination to do this?

@jmiguelv
Copy link
Member

No, go ahead if you have not already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jmiguelv @geoffroy-noel-ddh @brian-maher