Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rescue Exception #20

Open
nirvdrum opened this issue Jan 7, 2013 · 0 comments
Open

Don't rescue Exception #20

nirvdrum opened this issue Jan 7, 2013 · 0 comments

Comments

@nirvdrum
Copy link

nirvdrum commented Jan 7, 2013

This library rescues Exception all over the place, oftentimes not re-raising it. This is problematic since it'll swallow interrupts and prevent threads from exiting properly. You should really only rescue StandardError unless you intend on re-raising the exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant