-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align GVK format accepted by --channel
flag
#1871
Comments
/assign |
@dsimansk |
Yes, the same as for |
@xiangpingjiang are you still working on the issue ? If not, no problem, but we would then assign it to somebody else who is also interested. Please let me know until tomorrow, otherwise, I would unassign you if this is ok |
@rhuss |
/assign |
@rhuss is this sth still unassigned (and undone)? If so I want to take a look at this. |
AFAIK it's still an open issue, hapyy to support you if you would like to give it a try! |
/assign |
@EraKin575 please go ahead. |
@EraKin575 what made you think that I am not working on this issue? this was still on my list and looking at the cadence, 1 month seems normal. Pls ping the assignee first (in this case me) as these kinda issues are already long waiting issues (opened on sept 2023). In my case, it was only 1 month so you were wrong about my not being active on this issue. I was on a PTO and recently saw your message here from 4 days ago. Thanks for your collaboration. Next time hoping for a better communication;) |
This issue is stale because it has been open for 90 days with no |
Bug report
We should consider refactoring
--channel
flag onkn subscription create
to be aligned within the same GVK format as--sink
. There's common implementation for parsing it already, but for some reason it isn't used in case ofSubscriptions
.Expected behavior
The
--channel
flag accepts the same GVK format as--sink
and other similar option flags./kind bug
/kind good-first-issue
/kind cleanup
The text was updated successfully, but these errors were encountered: