Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from istio inject annotation to label #1969

Open
ReToCode opened this issue Sep 24, 2024 · 1 comment
Open

Migrate from istio inject annotation to label #1969

ReToCode opened this issue Sep 24, 2024 · 1 comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ReToCode
Copy link
Member

ReToCode commented Sep 24, 2024

Context

We use the istio annotation sidecar.istio.io/inject: true in Client and related extension repos. Istio deprecated the annotation a while ago (ref: https://istio.io/latest/docs/reference/config/analysis/ist0135/ and https://istio.io/latest/docs/reference/config/annotations/#SidecarInject). Downstream this starts to cause issues (e.g. with OSSM 3.x), so we should migrate to the according label.

cc @dsimansk this came up here. I was unable to get the "old" way to work with OSSM 3.x, but we probably should migrate to the label anyway (we updated the docs for the customer to do the same).

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

1 participant