Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the Knative code-gen to a Go-native tool #2809

Open
Tracked by #134
cardil opened this issue Sep 1, 2023 · 5 comments
Open
Tracked by #134

Rewrite the Knative code-gen to a Go-native tool #2809

cardil opened this issue Sep 1, 2023 · 5 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link
Contributor

cardil commented Sep 1, 2023

Expected Behavior

To fix knative/infra#134 we need to remove the shell wrapper, so the Knative projects could run the code-gen in go run ... native way.

Actual Behavior

Current code gen has a shell wrapper. Because of it Knative projects which use this code gen require the vendor directory.

@dprotaso
Copy link
Member

dprotaso commented Sep 1, 2023

Note for a bunch of the codegen we do - it could be generics now

@Priyansurout
Copy link

/assign

Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 10, 2024
@cardil
Copy link
Contributor Author

cardil commented Jun 28, 2024

/reopen
/remove-lifecycle stale
/triage accepted

Copy link

knative-prow bot commented Jun 28, 2024

@cardil: Reopened this issue.

In response to this:

/reopen
/remove-lifecycle stale
/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Jun 28, 2024
@knative-prow knative-prow bot reopened this Jun 28, 2024
@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants