Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I saw a very magical piece of code #92

Open
jellychen opened this issue Jan 22, 2024 · 0 comments
Open

I saw a very magical piece of code #92

jellychen opened this issue Jan 22, 2024 · 0 comments

Comments

@jellychen
Copy link

https://github.com/knightcrawler25/GLSL-PathTracer/blob/85c5167/thirdparty/RadeonRays/split_bvh.cpp

At 432 line

                // Calc SAH
                float sah = m_traversal_cost + (leftbox.surface_area() *
                    +rightbounds[i - 1].surface_area() * rightcount)  * invarea;

Should it be like this?

                // Calc SAH
                float sah = m_traversal_cost + (leftbox.surface_area() * leftcount
                    +rightbounds[i - 1].surface_area() * rightcount)  * invarea;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant