Skip to content
Vidar Holen edited this page Oct 4, 2015 · 7 revisions

SC2094 Make sure not to read and write the same file in the same pipeline.

Problematic code:

grep foo file.txt | sed -e 's/foo/bar/g' > file.txt

Correct code:

grep foo file.txt  | sed -e 's/foo/bar/g' > tmpfile && mv tmpfile file.txt

Rationale:

Each step in a pipeline runs in parallel.

In this case, grep foo file.txt will immediately try to read file.txt while sed .. > file.txt will immediately try to truncate it.

This is a race condition, and results in the file being partially or (far more likely) entirely truncated.

Exceptions

You can ignore this error if:

  • The file is a device or named pipe. These files don't truncate in the same way.
  • The command mentions the filename but doesn't read/write it, such as echo log.txt > log.txt.

ShellCheck

Each individual ShellCheck warning has its own wiki page like SC1000. Use GitHub Wiki's "Pages" feature above to find a specific one, or see Checks.

Clone this wiki locally