Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stage.d.ts make StageConfig container optional for use in node environment #1797

Closed
daniatic opened this issue Jul 23, 2024 · 4 comments
Closed

Stage.d.ts make StageConfig container optional for use in node environment #1797

daniatic opened this issue Jul 23, 2024 · 4 comments

Comments

@daniatic
Copy link

The readme states that the container property in StageConfig can be omitted for use in a Node environment. However, the type definition still requires the container property, causing a conflict. I can simply ignore this conflict, but would it be possible to make the property optional?
@lavrton
Copy link
Member

lavrton commented Jul 24, 2024

Interested in making a pull request?

daniatic pushed a commit to daniatic/konva that referenced this issue Jul 31, 2024
konvajs#1797 StageConfig: container optional
0d977a1
@daniatic
Copy link
Author

#1801

lavrton added a commit that referenced this issue Aug 1, 2024
@lavrton
Merge pull request #1801 from daniatic/master
583fccf 
#1797 StageConfig: container optional
@lavrton
Copy link
Member

lavrton commented Aug 1, 2024

Thanks

@lavrton lavrton closed this as completed Aug 1, 2024
@daniatic
Copy link
Author

daniatic commented Aug 1, 2024

No, thank you!

@duy0000 duy0000 mentioned this issue Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lavrton @daniatic