Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point cloud dataset doesn't allow no-CRS data #886

Open
olsen232 opened this issue Jul 10, 2023 · 1 comment
Open

Point cloud dataset doesn't allow no-CRS data #886

olsen232 opened this issue Jul 10, 2023 · 1 comment

Comments

@olsen232
Copy link
Collaborator

olsen232 commented Jul 10, 2023

To Reproduce
kart import some-laz-file-that-doesnt-have-a-crs.laz
(You can agree to constrain-to-COPC or not - makes no difference.)

Expected behaviour
Should import the tiles, even with no CRS.

Output
A stacktrace, ending with:
RuntimeError: OGR Error: Corrupt data

Version Info
kart 0.14
affects all platforms

Also TODO: check if we support GeoTIFF files with no CRS

@craigds
Copy link
Member

craigds commented Jul 10, 2023

Should import the tiles, even with no CRS.

Not sure I agree, the LAS spec is fairly clear that a CRS header must be present. And it doesn't make much sense to just generate a fake/empty one:

https://www.asprs.org/wp-content/uploads/2019/03/LAS_1_4_r14.pdf

The Coordinate Reference System (CRS) information for the point data is required for all data.

IMO:

  • we should have a --crs flag to kart point-cloud-import that lets you set/override the CRS of tiles while importing
  • we should import tiles with no CRS into a dataset with a CRS, but set the CRS on the imported tiles to the same as the dataset
  • we shouldn't let you import tiles with no CRS - i.e. if you're importing a new dataset from tiles that have no CRS, --crs will be required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants