Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal freeze after installing tab completions for fish shell #948

Open
andreatitolo opened this issue Nov 21, 2023 · 7 comments
Open

Comments

@andreatitolo
Copy link

Describe the bug
I installed the fish completions using kart install tab-completions --shell fish. When I start typing a kart command, pressing TAB freezes the terminal (doesn't matter the terminal emulator), without any completion showing up, and I am forced to quit the application.

I don't know if it matters, but fish is not my login shell.

To Reproduce
Steps to reproduce the behaviour:

  1. Install fish completions
  2. Type any kart command
  3. Press tab to bring up completions
  4. Terminal freezes

Expected behaviour
For the completions to show up properly and not freezing the terminal

Version Info

  • OS: macOS 13.6.2
  • Version: Kart 0.14.2
  • Shell: Fish 3.6.1
@rcoup
Copy link
Member

rcoup commented Nov 22, 2023

Hi!

Can you try doing export KART_USE_HELPER=0 and see if that makes any difference?

@andreatitolo
Copy link
Author

Setting set -gx KART_USE_HELPER 0 in my fish.conf (should be the equivalent of the above command) works! Just out of curiosity, what does that setting do?

@rcoup
Copy link
Member

rcoup commented Nov 22, 2023

Thanks — we use a background helper to speed up process startup for Kart on macOS + Linux. I guess it's interacting funkily with fish or tab completion somehow.

@andreatitolo
Copy link
Author

Thanks for explaining, I'll close the issue as I don't have any freeze anymore, and I did not notice any slowdown or similar.

@rcoup
Copy link
Member

rcoup commented Nov 24, 2023

I'll reopen it until someone gets a chance to try and reproduce it or figure out what the issue is.

@rcoup rcoup reopened this Nov 24, 2023
@craigds
Copy link
Member

craigds commented Nov 8, 2024

I'm getting this same behaviour on zsh (MacOS) and it's also kart-helper specific; tab completion works fine if the helper is disabled

@craigds
Copy link
Member

craigds commented Nov 8, 2024

actually a fresh kart install tab-completion --shell zsh fixes my zsh problem. so zsh must be not completely broken

However I can repro this with fish (and bash)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants