Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kart status doesn't differentiate between updates and conflicts #958

Open
1 of 2 tasks
olsen232 opened this issue Dec 12, 2023 · 0 comments
Open
1 of 2 tasks

kart status doesn't differentiate between updates and conflicts #958

olsen232 opened this issue Dec 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@olsen232
Copy link
Collaborator

olsen232 commented Dec 12, 2023

Originally, there were three types of change in a diff:

  • inserts
  • updates
  • deletes

However, as Kart gets more complex, it is possible for the user to put various changes into the working copy that may be uncommittable for various reasons. These are displayed as such in kart diff but not always summarised in kart status:

  • spatial filter conflict - user has tried to do an "insert", probably, but they've inadvertently reused a primary key value that was already in use outside the current spatial filter. so, this is actually an update, but we count it as a spatial filter conflict and don't let the user commit it unless they provide a special flag. kart status reports these correctly.
  • ListOfConflicts - user has managed to provide more than one conflicting value for a single dataset - for example, adding tiles with different CRSs to a single dataset, such that Kart doesn't know which CRS to commit as the dataset CRS. kart diff shows these as conflicts, but kart status summarises them as inserts or updates.
@olsen232 olsen232 added the enhancement New feature or request label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant