Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove range-parser dependency #18

Open
kotx opened this issue Sep 17, 2022 · 2 comments
Open

Remove range-parser dependency #18

kotx opened this issue Sep 17, 2022 · 2 comments

Comments

@kotx
Copy link
Owner

kotx commented Sep 17, 2022

R2 API can process range requests now, it seems. We can remove the range-parser dependency and directly pass the header instead.
@Erisa
Copy link
Collaborator

Erisa commented Nov 1, 2022

It looks like the functionality to pass request headers to R2GetOptions is not documented outside of changelogs... nor does it actually work.

✘ [ERROR] Uncaught (in promise) Error: get: We encountered an internal error. Please try again. (10001)

As far as I can tell this bug is acknowledged but has existed for a while now without a fix. So this issue would be blocked waiting for that being fixed in future.

@Frederik-Baetens
Copy link

This should be fixed now. Let me know if you encounter any more issues surrounding this functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Erisa @Frederik-Baetens @kotx