Performance issue in /awesome_gans/pggan (by P3)

[DLPerf]

Hello! I've found a performance issue in /awesome_gans/pggan/pggan_train.py: with tf.Session(config=config) as s(here) is repeatedly called in the loop for idx, n_pg in enumerate(pg)(here).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient. Here is the Stack Overflow post to support it.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

[kozistr]

First of all, thanks for your interest!

Also, thanks so much to report the performance issue on the PGGAN implementation, and PR is always welcome :)

I'm about to port the whole code into TF 2.x to support the latest TF version & resolve compatibility issues. But, I got few resources (time, hardware) these days, So maintaining TF 1.x code is also crucial!

The issue & solution you mentioned make sense, and It'd be really appreciated that opening a PR!

Thanks again!