Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input namespaces can be left dangling when unconnected #308

Open
Tracked by #291
jsbrittain opened this issue Jul 24, 2024 · 1 comment
Open
Tracked by #291

Input namespaces can be left dangling when unconnected #308

jsbrittain opened this issue Jul 24, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jsbrittain
Copy link
Collaborator

jsbrittain commented Jul 24, 2024

For example, a module can have two input ports:

input_namespace:
    data: data
    config: config

When connecting a module to the 'data' input, the 'data' namespace is remapped; however, if the 'config' port is not connected then it can be left dangling pointing at 'config'. It should probably be nullified (set to ""). This would allow port connections to be tested in the module's Snakefile, and prevent inadvertent linkages.

The Anderson Brito Subsampler is a good use-case to test this with: kraemer-lab/vneyard#35, where the config port should act as an override rather than a requirement. edit: This may not be the best example as the 'keep' config file is a required input.

@jsbrittain jsbrittain mentioned this issue Jul 24, 2024
32 tasks
@jsbrittain
Copy link
Collaborator Author

By default, GRAPEVNE will turn any workflow into a single module and attempt to launch it. This means that, in the above example, the dangling 'config' namespace will be remapped as an input to the wider 'parent' module. This could either be stopped (by removing the module construction prior to launch), or the parent input could default to the empty string (this cannot be null as this has special significance as a 'source' module; although since the inputs are named this could be overcome).

@jsbrittain jsbrittain added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant