You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have identified a few errors that zoid throws that cannot be caught by the implementation code (render.catch() and close.catch()). If the container element is removed from the DOM or the user is navigating away from the page mid-render, we should avoid throwing errors.
We have identified a few errors that zoid throws that cannot be caught by the implementation code (
render.catch()
andclose.catch()
). If the container element is removed from the DOM or the user is navigating away from the page mid-render, we should avoid throwing errors.Here are 3 examples:
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L857
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L826
https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L1172
These 3 error flows eventually cause the promise to be rejected since the render was never completed, and an error to be displayed on the console: https://github.com/krakenjs/zoid/blob/main/src/parent/parent.js#L732
Would adding additional checks to prevent an error from being thrown be sufficient?
The text was updated successfully, but these errors were encountered: