Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The behavior of certificate in StorageSpec is different from Kserve #460

Open
Jooho opened this issue Nov 27, 2023 · 1 comment
Open

The behavior of certificate in StorageSpec is different from Kserve #460

Jooho opened this issue Nov 27, 2023 · 1 comment

Comments

@Jooho
Copy link
Contributor

Jooho commented Nov 27, 2023

Is your feature request related to a problem? If so, please describe.
certificate in KServe can be set by serving.kserve.io/s3-bundle and this field is for the path of ca bundle certificate.

However, in modelmesh, this is ca bundle certificate content

To me, kserve way would be the right approach.
KServe provide a way to attach a configmap for cabundle and also can change the cert path globally. Moreover, it also can be set by StorageSpec

Describe your proposed solution
Modelmesh need to implement the same reconciler to copy the ca configmap to the user namespace and follow the same behavior of kserve one.

Describe alternatives you have considered

Additional context

@Jooho
Copy link
Contributor Author

Jooho commented Jun 11, 2024

Modelmesh was using another way to support dynamic update of certificate without restarting runtime pod.
However, if we use configmap like kserve, I think it does not need to restart runtime. So we can consider to change this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant