Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing build info in KubeArmor systemd package #1921

Open
DelusionalOptimist opened this issue Dec 20, 2024 · 8 comments · May be fixed by #1928
Open

Missing build info in KubeArmor systemd package #1921

DelusionalOptimist opened this issue Dec 20, 2024 · 8 comments · May be fixed by #1928
Assignees
@Atharva-Kanherkar
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@DelusionalOptimist
Copy link
Member

Bug Report

General Information

  • Environment description - systemd
  • Kernel version (run uname -a) - NA
  • Orchestration system version in use (e.g. kubectl version, ...) - NA
  • Link to relevant artifacts (policies, deployments scripts, ...) - NA
  • Target containers/pods - NA

To Reproduce

  1. Run KubeArmor in systemd mode - https://github.com/kubearmor/KubeArmor/blob/main/getting-started/kubearmor_vm.md
  2. Pull up the logs using sudo journalctl -xeu kubearmor.service -f and try to look for BUILD-INFO.. you won't find it.

Expected behavior

Build info should be present in the logs... it would look something like below
image

This information comes from govvv. It's already present in KubeArmor's K8s image because we inject it while building - https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/Makefile#L35
Need to do the same in goreleaser - https://github.com/kubearmor/KubeArmor/blob/main/KubeArmor/.goreleaser.yaml
@DelusionalOptimist DelusionalOptimist added bug Something isn't working good first issue Good for newcomers labels Dec 20, 2024
@Atharva-Kanherkar
Copy link

hi @DelusionalOptimist I am just starting with learning the codebase:) if this isnt very urgent and i can take some time, id like to take this up!

@Atharva-Kanherkar
Copy link

Hi @DelusionalOptimist I have injected build info into the goreleaser. But I cant test it, I am having some problems testing it, particularly while building it in systemd mode. Can I get some guidance on that please!:)

@tesla59
Copy link
Contributor

tesla59 commented Dec 24, 2024

hey @Atharva-Kanherkar
could u please link your PR, and also what is the issue u faced while building it in systemd mode?

@Atharva-Kanherkar
Copy link

hey @Atharva-Kanherkar
could u please link your PR, and also what is the issue u faced while building it in systemd mode?

Hi, can I just make a pr without testing it?

@tesla59
Copy link
Contributor

tesla59 commented Dec 24, 2024

@Atharva-Kanherkar sure. u can create a draft pr

@Atharva-Kanherkar
Copy link

Hello, @DelusionalOptimist , These are the logs I am getting currently, can you please confirm this is what we wanted with the issue :
image
Thank you for your time!

@Atharva-Kanherkar
Copy link

image
I hope these were the results we were hoping for!:)

@tesla59
Copy link
Contributor

tesla59 commented Dec 25, 2024

@Atharva-Kanherkar looks like its working fine now. can u raise the PR?

@Atharva-Kanherkar Atharva-Kanherkar linked a pull request Dec 25, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Atharva-Kanherkar Atharva-Kanherkar

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): inject Build Info into systemd package Atharva-Kanherkar/KubeArmor
3 participants
@tesla59 @DelusionalOptimist @Atharva-Kanherkar