Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment variable name USERNAME is likely to be in use already #274

Open
mickvangelderen opened this issue Nov 21, 2024 · 1 comment
Open

Environment variable name USERNAME is likely to be in use already #274

mickvangelderen opened this issue Nov 21, 2024 · 1 comment

Comments

@mickvangelderen
Copy link
Contributor

mickvangelderen commented Nov 21, 2024 •
edited
Loading

The USERNAME variable defaults to kubernetes which is great except when it is defined by something else on your system. I'm using a fairly new installation of ubuntu 24.04 and something has defined USERNAME already to be the same as USER.

This caused generation to fail and I had to look into why. This not a good user experience. My suggested solution would be to prefixing the variable names so they end up being a bit more unique.
@brendandburns
Copy link
Contributor

Happy to take a PR for this, perhaps GITHUB_USERNAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mickvangelderen @brendandburns