Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support node selector for each profile #1486

Open
songtao98 opened this issue Aug 14, 2024 · 1 comment
Open

Support node selector for each profile #1486

songtao98 opened this issue Aug 14, 2024 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@songtao98
Copy link

Is your feature request related to a problem? Please describe.

There are use cases such as to config HighNodeUtilization plugin with different threshold in different group of nodes, e.g. nodepools. However, most of the plugins only supports to filter pods through specific filters.

Describe the solution you'd like

When dealing with nodes, it is the framework to decide which nodes can be the targets. And it is configured by a global NodeSelector. So the idea is to add a new arg into Profile. Nodes that passed the global NodeSelector will be filtered again by each profile's NodeSelector and then passed into pg.Balance() or pg.Deschedule(). However, this might change the way how you build plugins.

Describe alternatives you've considered

For each plugin, add NodeSelector configuration to filter nodes passed into it.

What version of descheduler are you using?

descheduler version: v0.26.0 and later

Additional context

@songtao98 songtao98 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 14, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants