[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rikatz
Once this PR has been reviewed and has the lgtm label, please assign frapposelli for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

BTW, i just found out that cloud-provider has a cluster-name field https://github.com/kubernetes/cloud-provider/blob/152995bd25ae20bc618a9ba7039a1b683372c86c/config/types.go#L71
This was used for serviceController previously. Sorry I didn't found it before. But yeah you make it clear inside the description of the new field.

Could you also add to ini type config as well? Downstream product still use that one https://github.com/rikatz/cloud-provider-vsphere/blob/different-user-agent/pkg/common/config/config_ini_legacy.go
But it just reminds me we should switch over to new type of config.

Or do you think we can just previous clusterName value?

Or do you think we can just previous clusterName value?

The goal is to identify it on userAgent, so if clusterName does the job, why not? :) I will work on it next week, thanks!!

I am confused now that I am checking it, it is cloud-provider and not cloud-provider-vsphere?

@lubronzhan what's the path we should take? add ClusterName to some config structure? clusterID? I've seen there is also a flag on main with cluster name https://github.com/kubernetes/cloud-provider-vsphere/blob/master/cmd/vsphere-cloud-controller-manager/main.go#L135

Maybe we can just use this flag instead

Yeah I think you are right, this is the flag added before https://github.com/kubernetes/cloud-provider-vsphere/blob/master/cmd/vsphere-cloud-controller-manager/main.go?rgh-link-date=2023-12-19T13%3A39%3A42Z#L135
And that is passed to the cloud-provider's ClusterName as a config.
Sorry I didn't find the right one before

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-triage-robot: Closed this PR.