Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: workload charts are black for certain languages #9067

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: workload charts are black for certain languages #9067

wants to merge 3 commits into from

Conversation

HanNguyen-dev
Copy link

@HanNguyen-dev HanNguyen-dev commented May 21, 2024 •
edited
Loading

For certain languages such as KR and FR, the workload charts are black.

The current code is pulling out the translation for the different statuses by passing Running, Succeeded, etc; just that there are different texts (3) starting with Running, Succeeded, etc.

The code change passes in an empty string for placeholder to mimic how status label names were generated; thus the translated text will be a substring of the status label names.

dashboard/modules/web/src/overview/helper.ts

Lines 30 to 34 in 5d6805d

let items = [
{
name: $localize`Running: ${status.running}`,
value: (status.running / totalItems) * 100,
},

Steps to reproduce bug (french)

See commit HanNguyen-dev@8ca2535 for details

In the angular.json

  1. Add new build configuration for development and fr
      "development": {
          "localize": false,
          "optimization": false,
          "extractLicenses": false,
          "sourceMap": true
      },
      "fr": {
          "localize": ["fr"],
      },
  1. Add new serve configuration
       "configurations": {
          "fr": {
             "browserTarget": "kubernetes-dashboard:build:development,fr"
          }
       }

In the dev.serve.sh

dashboard/modules/web/hack/scripts/dev.serve.sh

Line 21 in 4f3d800

npx ng serve --proxy-config=proxy.conf.json --host=0.0.0.0 --disable-host-check --poll=2000

1. Pass in the --configuration=fr.

npx ng serve --proxy-config=proxy.conf.json --configuration=fr --host=0.0.0.0 --disable-host-check --poll=2000

Run make serve

Screenshots

Before

Screenshot from 2024-12-19 21-34-45

After

Screenshot from 2024-12-19 21-43-22

closes #8898
closes #8753

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 21, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @HanNguyen-dev!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 21, 2024
@HanNguyen-dev HanNguyen-dev changed the title fix: workload charts are black for certain lang\auages fix: workload charts are black for certain languages May 21, 2024
@Amphaal
Copy link

Amphaal commented Jun 17, 2024

Nice fix @HanNguyen-dev, thanks. LFT it being merged !

@gdelvallez1
Copy link

I agree , it is a nice fix. It will Help to fix the issue in all languages at once.
/lgtm

@k8s-ci-robot
Copy link
Contributor

@gdelvallez1: changing LGTM is restricted to collaborators

In response to this:

I agree , it is a nice fix. It will Help to fix the issue in all languages at once.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gdelvallez1, HanNguyen-dev
Once this PR has been reviewed and has the lgtm label, please assign floreks for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vittoriocanilli
Copy link

Nice fix, @HanNguyen-dev !
Do you know why it is not going through?
Does it maybe need the review from @maciaszczykm or @shu-mutou ?

@HanNguyen-dev
Copy link
Author

HanNguyen-dev commented Dec 19, 2024 •
edited
Loading

Hi @vittoriocanilli, I forgot that this PR is still here. I am not familiar with PR process to be honest, but I'll go through their documentation to see what is missing.

I'll pull the latest from master as well, and add some steps to reproduce this bug locally.

@HanNguyen-dev
Copy link
Author

/assign @maciaszczykm
/assign @shu-mutou

Can you review this PR? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm

@shu-mutou shu-mutou Awaiting requested review from shu-mutou

At least 1 approving review is required to merge this pull request.

Assignees

@maciaszczykm maciaszczykm

@shu-mutou shu-mutou

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workload status with black graphs in DE, ES, FR and ZH No fill on workload charts for some languages
7 participants
@HanNguyen-dev @k8s-ci-robot @Amphaal @gdelvallez1 @vittoriocanilli @maciaszczykm @shu-mutou