Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to gopkg.in/yaml.v3 #33971

Open
BenTheElder opened this issue Dec 16, 2024 · 9 comments · Fixed by #33979 or GoogleCloudPlatform/testgrid#1301
Open

switch to gopkg.in/yaml.v3 #33971

BenTheElder opened this issue Dec 16, 2024 · 9 comments · Fixed by #33979 or GoogleCloudPlatform/testgrid#1301
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@BenTheElder
Copy link
Member

https://github.com/kubernetes/test-infra/pull/33958/files#r1886682875

/priority backlog

we may also have to update dependency repos like sigs.k8s.io/prow

@BenTheElder BenTheElder added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 16, 2024
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 16, 2024
@BenTheElder
Copy link
Member Author

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 16, 2024
@mkumatag
Copy link
Member

/assign

@BenTheElder
Copy link
Member Author

(#33979 (comment))

@mkumatag
Copy link
Member

This is because of the following reason

$ go mod why -m gopkg.in/yaml.v3
# gopkg.in/yaml.v3
k8s.io/test-infra/experiment/coverage
github.com/go-openapi/spec    <====== (1)
github.com/go-openapi/swag
gopkg.in/yaml.v3
$ go mod why -m gopkg.in/yaml.v2
# gopkg.in/yaml.v2
k8s.io/test-infra/config/tests/mergelists
k8s.io/test-infra/config/tests/mergelists.test
github.com/GoogleCloudPlatform/testgrid/pkg/merger <====== (2)
gopkg.in/yaml.v2

(1) and (2) are imported modules that use these indirect dependencies. They are outside of the Kubernetes project, and we have minimal control over them.

@BenTheElder
Copy link
Member Author

Testgrid is us and can be patched cc @michelle192837

(1) I'm less sure about. cc @pohly @jpbetz

@BenTheElder
Copy link
Member Author

In kubernetes when we encounter this sort of issue we usually reach out to the intermediate projects to discuss. But I'm not sure if this is a reasonable ask in this case

@mkumatag
Copy link
Member

Testgrid is us and can be patched cc @michelle192837

I see that they are using sigs.k8s.io/yaml module already, I can submit a PR to remove dependency from gopkg.in/yaml

https://github.com/GoogleCloudPlatform/testgrid/blob/3ad1f7c3c6a8b9085998213c1cc2cbd1eb80c3e4/go.mod#L33

@mkumatag
Copy link
Member

Testgrid is us and can be patched cc @michelle192837

I see that they are using sigs.k8s.io/yaml module already, I can submit a PR to remove dependency from gopkg.in/yaml

https://github.com/GoogleCloudPlatform/testgrid/blob/3ad1f7c3c6a8b9085998213c1cc2cbd1eb80c3e4/go.mod#L33

submitted this PR in the testgrid - GoogleCloudPlatform/testgrid#1301

@pohly
Copy link
Contributor

pohly commented Dec 18, 2024

I don't think we need to be pedantic about this. Not depending on it in code that we as Kubernetes own should be good enough. We explicitly should not as other projects to use sigs.k8s.io/yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
4 participants