-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to gopkg.in/yaml.v3 #33971
switch to gopkg.in/yaml.v3 #33971
Comments
/sig testing |
/assign |
This is because of the following reason
(1) and (2) are imported modules that use these indirect dependencies. They are outside of the Kubernetes project, and we have minimal control over them. |
Testgrid is us and can be patched cc @michelle192837 |
In kubernetes when we encounter this sort of issue we usually reach out to the intermediate projects to discuss. But I'm not sure if this is a reasonable ask in this case |
I see that they are using sigs.k8s.io/yaml module already, I can submit a PR to remove dependency from gopkg.in/yaml |
submitted this PR in the testgrid - GoogleCloudPlatform/testgrid#1301 |
I don't think we need to be pedantic about this. Not depending on it in code that we as Kubernetes own should be good enough. We explicitly should not as other projects to use sigs.k8s.io/yaml. |
https://github.com/kubernetes/test-infra/pull/33958/files#r1886682875
/priority backlog
we may also have to update dependency repos like sigs.k8s.io/prow
The text was updated successfully, but these errors were encountered: