Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minio out of storage - the test fails on saving artifacts, no execution logs #4847

Open
tkonieczny opened this issue Dec 28, 2023 · 2 comments
Labels
bug 🐛 Something is not working as should be

Comments

@tkonieczny
Copy link
Contributor

tkonieczny commented Dec 28, 2023

Describe the bug
When minio out of storage (Storage backend has reached its minimum free drive threshold) the test fails with:

execution pod 658b003d382af015eee15126-k79v7 failed
error scraping artifacts for Artillery executor: error processing object artifacts.tar.gz: error saving file artifacts.tar.gz: minio saving file (658b003d382af015eee15126/artifacts.tar.gz) put object error: Storage backend has reached its minimum free drive threshold. Please delete a few objects to proceed.

Example: https://demo.testkube.dev/tests/artillery-executor-smoke/executions/658b003d382af015eee15126

Expected behavior
Saving artifacts shouldn't fail the test - the test should be executed correctly, execution logs should be available.

@tkonieczny tkonieczny added the bug 🐛 Something is not working as should be label Dec 28, 2023
@vsukhin
Copy link
Collaborator

vsukhin commented Jan 22, 2024

This looks, like a business decision or might be even better to use a flag failOnArtifactScrapingError. For some users this is not important, for other ones, it might be critical

@rangoo94
Copy link
Member

It's quite useful to fail on the artifacts problem - otherwise, you may be surprised when there will be actual error, but no artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is not working as should be
Projects
None yet
Development

No branches or pull requests

3 participants