Skip to content

Latest commit

 

History

History
33 lines (23 loc) · 1.84 KB

CONTRIBUTING.md

File metadata and controls

33 lines (23 loc) · 1.84 KB

Contributing

Legal

By submitting a pull request, you represent that you have the right to license your contribution to the community, and agree by submitting the patch that your contributions are licensed under the Apache 2.0 license (see LICENSE).

Contributor Conduct

All contributors are expected to adhere to the project's Code of Conduct.

Submitting a bug or issue

Please ensure to include the following in your bug report

  • A consise description of the issue, what happened and what you expected.
  • Simple reproduction steps
  • Version of the library you are using
  • Contextual information (Swift version, OS etc)

Submitting a Pull Request

Please ensure to include the following in your Pull Request

  • A description of what you are trying to do. What the PR provides to the library, additional functionality, fixing a bug etc
  • A description of the code changes
  • Documentation on how these changes are being tested
  • Additional tests to show your code working and to ensure future changes don't break your code.

Remember the requirements for Hummingbird and HummingbirdCore (No Foundation and no new dependencies). If you are submitting a large change to a module (or bringing in a new dependency) please consider making these changes in a separate repository. The idea is that Hummingbird/HummingbirdCore are kept as slimline as possible. These concerns can be discussed in a Github Issue.

Please keep your PRs to a minimal number of changes. If a PR is large try to split it up into smaller PRs. Don't move code around unnecessarily it makes comparing old with new very hard.

The main development branch of the repository is main.

Formatting

We use Nick Lockwood's SwiftFormat for formatting code. PRs will not be accepted if they haven't be formatted. The current version of SwiftFormat we are using is v0.48.17.