From 78a1d2004600156cc009737f5d748c0ed7a9bd5f Mon Sep 17 00:00:00 2001 From: Chang Liu Date: Wed, 16 Oct 2024 21:12:53 -0400 Subject: [PATCH] Enable assertion --- .github/workflows/ci-workflow.yml | 1 + CMakeLists.txt | 3 ++- Makefile | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-workflow.yml b/.github/workflows/ci-workflow.yml index 16a3c48c3a..523ab95f15 100644 --- a/.github/workflows/ci-workflow.yml +++ b/.github/workflows/ci-workflow.yml @@ -317,6 +317,7 @@ jobs: WERROR: 0 TEST_JOBS: 12 NUM_THREADS: 32 + CCACHE_DISABLE: 1 steps: - uses: actions/checkout@v4 diff --git a/CMakeLists.txt b/CMakeLists.txt index c0936098ca..9b47ac8530 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -143,12 +143,13 @@ if(BUILD_WASM) add_link_options(-pthread) add_link_options(-sPTHREAD_POOL_SIZE=8) add_compile_options(-s DISABLE_EXCEPTION_CATCHING=0) - # add_link_options(-sALLOW_MEMORY_GROWTH=1) if(BUILD_TESTS) add_link_options(-sINITIAL_MEMORY=3584MB) # 3.5GB add_link_options(-sNODERAWFS=1) + add_link_options(-sASSERTIONS=1) else() add_link_options(-sINITIAL_MEMORY=2GB) + add_link_options(-sALLOW_MEMORY_GROWTH=1) endif() set(__WASM__ TRUE) add_compile_options(-fexceptions) diff --git a/Makefile b/Makefile index d6f3645384..3aa7a1606e 100644 --- a/Makefile +++ b/Makefile @@ -169,7 +169,7 @@ rusttest: rust wasmtest: mkdir -p build/wasm && cd build/wasm &&\ - emcmake cmake $(GENERATOR) $(FORCE_COLOR) $(SANITIZER_FLAG) $(WERROR_FLAG) $(RUNTIME_CHECK_FLAG) -DCMAKE_BUILD_TYPE=Release -DBUILD_WASM=TRUE -DBUILD_BENCHMARK=FALSE -DBUILD_TESTS=TRUE -DBUILD_SHELL=FALSE -DENABLE_WERROR=FALSE ../.. && \ + emcmake cmake $(GENERATOR) $(FORCE_COLOR) $(SANITIZER_FLAG) $(WERROR_FLAG) $(RUNTIME_CHECK_FLAG) -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_WASM=TRUE -DBUILD_BENCHMARK=FALSE -DBUILD_TESTS=TRUE -DBUILD_SHELL=FALSE -DENABLE_WERROR=FALSE ../.. && \ cmake --build . --config Release -j $(NUM_THREADS) &&\ cd ../.. && ctest --test-dir build/wasm/test/ --output-on-failure -j ${TEST_JOBS} --timeout 600