-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect selectAll
typing
#1059
Comments
Hey 👋 Thank you for submitting this crucial issue! As a workaround, please scope the selectAll('pet') |
To solve this we need to find a way to track the "external" query context (tables that exist in the main query's My intuition points at an additional (4th) generic @ We are usually conservative when it comes to adding more generics. However, output type correctness is important, and these helpers are frequently used, so IMHO this time it's worth it. |
I strongly disagree with this one. I definitely don't think we should add a fourth generic just for this case as it's easily fixed by using |
As an option, |
|
Hello dear maintainers, I found an incorrect typing in the Not null docs:
SQL is correctly selecting * from the pet table, so only the pet columns are actually selected, but the typing combines columns of all tables.
The text was updated successfully, but these errors were encountered: