Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] clarify expectation around schemaValidation flag and .spec.schemaValidation #1347

Open
FrancoisPoinsot opened this issue Sep 13, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@FrancoisPoinsot
Copy link

FrancoisPoinsot commented Sep 13, 2024

Description

As far as I understand schemaValidation doesn't serve a purpose anymore. Both as a command flag and as a the .spec. schemaValidation field in the a policy.

You can still find reference about that field in the documentation that hints it is a valid workaround for solving problems related to missing CRD.
Example: https://kyverno.io/docs/writing-policies/tips/#validate.

And this workaround makes sense. As you might expect kyverno validation to be dynamically typed.
I certainly did.

This issue is a follow up to that thread: https://kubernetes.slack.com/archives/CLGR9BJU9/p1719931376972489
In there you can find the statement "That's correct, a CRD is always required.". I think this is a very clear statement that I wish would be directly available in the documentation.

recommendation:

  • state clearly in the documentation that CRD is always required
  • cleanup references to schemaValidation that are not about deprecation.

Slack discussion

https://kubernetes.slack.com/archives/CLGR9BJU9/p1719931376972489

@FrancoisPoinsot FrancoisPoinsot added the enhancement New feature or request label Sep 13, 2024
Copy link

welcome bot commented Sep 13, 2024

Thanks for opening your first issue here! Be sure to follow the issue template!

@realshuting realshuting added the good first issue Good for newcomers label Sep 16, 2024
@lavishpal
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

3 participants