Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_polyface methods to Sphere, Cone and Cylinder #85

Open
chriswmackey opened this issue Jan 27, 2020 · 4 comments
Open

Add to_polyface methods to Sphere, Cone and Cylinder #85

chriswmackey opened this issue Jan 27, 2020 · 4 comments
Labels
enhancement New feature or request geometry good first issue Good for newcomers ladybug triage wish New feature or request which is not critical to continued development at this point

Comments

@chriswmackey
Copy link
Member

In order to make use of the Sphere, Cone, and Cylinder objects within honeybee workflows, we will need some way to translate these objects to approximations of planar geometry for simulation engines that do not natively support Sphere, Cone, and Cylinder primitives (eg. EnergyPlus). If we can add a to_polyface methods to each of these objects that can return such planar approximations, this should allow for this to happen with ease. I imagine that such a method could have input arguments to specify the number of times the "circle" contained within each one is subdivided and we could have some coarse default like 8.

@chriswmackey chriswmackey added enhancement New feature or request wish New feature or request which is not critical to continued development at this point ladybug geometry labels Jan 27, 2020
@santiagogaray
Copy link
Contributor

Hi @chriswmackey
I was wondering if this project may have priority over others. I do have some questions before tackling it if we go ahead with it.

@chriswmackey
Copy link
Member Author

Hi @santiagogaray ,

If you are asking what would be most immediately helpful, cleaning up the documentation of the other repos would be at the top. The sooner that we have that, the sooner other developers can make use of the other Python packages ... and the sooner that you can send us the invoice for your subcontract and we can process it. Realistically, we won't be able to make use of the Sphere, Cone and Cylinder objects in honeybee for another few months after we have gotten some other critical things in place.

@santiagogaray
Copy link
Contributor

Understood @chriswmackey, will start with the documentation cleanup next!

@chriswmackey chriswmackey added the good first issue Good for newcomers label May 3, 2020
@Erwin-T
Copy link

Erwin-T commented Aug 11, 2021

Hi @chriswmackey
Can I help with this issue by contributing code for the specified task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request geometry good first issue Good for newcomers ladybug triage wish New feature or request which is not critical to continued development at this point
Projects
None yet
Development

No branches or pull requests

3 participants