fix: avoid lost attestations and sync committee messages with early subnet subscribe #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tible roots in subnetinfo
|
A 40 epoch run in the mainnet spec showing sync aggregate almost always at 100% after the early subscribe |
Arkenan
approved these changes
Sep 23, 2024
| @@ -41,8 +41,16 @@ defmodule LambdaEthereumConsensus.Validator.Duties do | |||
| aggregation: [sync_committee_aggregator_duty()] | |||
| } | |||
|
|
|||
| @type subnets :: MapSet.t(Types.uint64()) | |||
There was a problem hiding this comment.
nit: maybe add a comment on what a subnet is and what the uint is here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some messages from sync committees and attestations weren't part of their aggregates due to late subscribes to the subnets, this PR address it
Description
This PR adds the subnets per slot to our shared duties and also adds a new key in the validator set struct to hold our last subnets subscribed to. On the first third of every slot, we check for the difference between the previous subnets and the new ones and do the appropriate unsubscribe/subscribe when needed. Apart from it this PR tackles an issue when receiving messages for non existing subnets crashed Libp2p.
Resolves #1300
Resolves #1301