Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor jassert and log #23

Closed
9 tasks done
lamogui opened this issue Aug 10, 2019 · 2 comments
Closed
9 tasks done

Refactor jassert and log #23

lamogui opened this issue Aug 10, 2019 · 2 comments
Assignees
Labels
feature complete new feature TODO Not really a feature... just a reminder

Comments

@lamogui
Copy link
Owner

lamogui commented Aug 10, 2019

  • rename jassert in passert and jassertfalse in passertfalse
  • make passert also break in debug
  • remove all LogWidget get parent shit etc etc,
  • make an abstract class log which have no deal with any widget (no Qt in .h)
  • add a global instatiation of this class
  • add a message in passert and reoprt it in the log
  • add a filter parameter in assert and log class
  • also add a void* or something like this to get the origin
  • make all the error shit etc thread safe
  • Make a dedicated error widget that select the concerned widget when clicking on error... delayed in Dedicated Log::Entry widget #26
@lamogui lamogui self-assigned this Aug 10, 2019
@lamogui lamogui added feature complete new feature TODO Not really a feature... just a reminder labels Aug 10, 2019
@lamogui
Copy link
Owner Author

lamogui commented Sep 1, 2019

There is still QObject and QString in the file for convenience and easy thread safety based on signal/slots !

lamogui added a commit that referenced this issue Sep 15, 2019
lamogui added a commit that referenced this issue Oct 23, 2019
lamogui added a commit that referenced this issue Oct 23, 2019
lamogui added a commit that referenced this issue Oct 23, 2019
lamogui added a commit that referenced this issue Oct 23, 2019
@lamogui
Copy link
Owner Author

lamogui commented Oct 23, 2019

Done in branch new_master ! yeah !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature complete new feature TODO Not really a feature... just a reminder
Projects
None yet
Development

No branches or pull requests

1 participant