Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine object is not being properly disposed in PGVector #126

Open
ladi-pomsar opened this issue Oct 14, 2024 · 0 comments
Open

Engine object is not being properly disposed in PGVector #126

ladi-pomsar opened this issue Oct 14, 2024 · 0 comments

Comments

@ladi-pomsar
Copy link

ladi-pomsar commented Oct 14, 2024

Hi everyone,

In #64 del method (lines 326-328) was removed from VectorStores.PGVector. While, after a bit of investigation, I believe this was a right decision, I would say it might need to be reintroduced. The way code currently is, the Engine object (stored in self._engine) doesn't dispose properly, upon deletion, if it is initialized from string by user through the connection parameter (as for lines 432 to 438).

I have faced "too many connections" error that seem to be fixed by disposing the engine with .dispose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant