Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to override query building logic #134

Open
Voileexperiments opened this issue Oct 28, 2024 · 0 comments
Open

Provide a way to override query building logic #134

Voileexperiments opened this issue Oct 28, 2024 · 0 comments

Comments

@Voileexperiments
Copy link

Currently __query_collection is double underscore prefixed, which means it takes some extra effort to override the logic for building the queries.

This makes the class completely inextensible and non-customizable. It's also very strange, since if I'm using postgres (compared to something infinitely easier to setup and use, like ChromaDB) to operate embedding data, obviously I'm trying to utilize its RDBMS features, which means I might want to customize my queries to join tables. With the current design it's not "intended" for users to do this in the first place, which makes the class very useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant