Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotstuff breaks on command + shift + something #8

Open
mesqueeb opened this issue Feb 27, 2019 · 3 comments
Open

Hotstuff breaks on command + shift + something #8

mesqueeb opened this issue Feb 27, 2019 · 3 comments

Comments

@mesqueeb
Copy link
Contributor

This is my biggest hurdle with the library.

When I do eg. meta+up (command+up on mac) it listens once, and also on more strokes of the up-key, but once I let go the command key, hotstuff stops listening completely to anything.

I wasn't able to reproduce this on Codepen, so let me know if you want me to show in my app on my screen.

@mesqueeb
Copy link
Contributor Author

Sorry it's actually not always reproducible on my end as well.
It's just very often that Hotstuff breaks and stops listening until a refresh of the page.

One case that it is reproducible for me

  1. make a change to my database in another tab.
  2. This causes my app's listener to update the DOM accordingly.
  3. Hotstuff stops listening

This is every single time. But it's a setup with a Firebase backend, so I'm not sure what's the real cause.

@mesqueeb
Copy link
Contributor Author

mesqueeb commented Feb 27, 2019

After much testing I found more cases that break the Hotstuff listener:

  • command + shift + control + ' which is for me the command to take a partial screen screenshot
  • command + shift + 5 which is for me the command to start a partial screen gif recording via the app called Gifox.

→ I tried all other commands with command + shift + something and even if the command + shift + something has no native function set up, it still stops listening.

command (meta) + shift seems to be the culprit...

@mesqueeb mesqueeb changed the title Hotstuff stops listening after one keystroke with modifier Hotstuff breaks on command + shift + something Feb 27, 2019
@mesqueeb
Copy link
Contributor Author

mesqueeb commented Mar 3, 2019

I'm starting to get the feeling that this might be because macOS does not register keyup events for key modifiers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant