Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag key doesn't support an array of primary key #1517

Open
reyadrian opened this issue Nov 29, 2024 · 1 comment
Open

Tag key doesn't support an array of primary key #1517

reyadrian opened this issue Nov 29, 2024 · 1 comment

Comments

@reyadrian
Copy link

reyadrian commented Nov 29, 2024

Horizon Version

5.29

Laravel Version

10.33

PHP Version

8.2.25

Redis Driver

Predis

Redis Version

2.2

Database Driver & Version

No response

Description

I have extended the eloquent model using a DynamoDB connection with Model::getKey() value of an array.
i.e. ['primary' => 1, 'sort_key' => 1]

The issue is that the tag creation process doesn't support converting an array value into a string when passing the model to the dispatch.

Error:

{
  "file": "<project>/vendor/laravel/framework/src/Illuminate/Foundation/Bootstrap/HandleExceptions.php",
  "line": 254,
  "function": "handleError",
  "class": "Illuminate\\Foundation\\Bootstrap\\HandleExceptions",
  "type": "->",
  "args": [
    2,
    "Array to string conversion",
    "<project>/vendor/laravel/horizon/src/Tags.php",
    37
  ]
}

File: Tags.php
Method:

public static function for($job)
    {
        if ($tags = static::extractExplicitTags($job)) {
            return $tags;
        }

        return static::modelsFor(static::targetsFor($job))->map(function ($model) {
            return get_class($model).':'.$model->getKey();
        })->all();
    }

If it's an array it should allow concatenating the values to a string as the getKey() method has mixed data types.
implode('-',$model->getKey())

Steps To Reproduce

Passing a model with an array of primary key to the Job TestJob::dispatch($model);

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here?

Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.

laravel new bug-report --github="--public"

Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants