Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify vite config in templates #401

Closed
dk1a opened this issue Feb 14, 2023 · 2 comments
Closed

Simplify vite config in templates #401

dk1a opened this issue Feb 14, 2023 · 2 comments
Assignees
Labels
refactor Clean up code without adding or removing features

Comments

@dk1a
Copy link
Contributor

dk1a commented Feb 14, 2023

Now that #328 is merged, after it's published it may be worth checking whether the verbose exclude+include are still necessary in templates vite.config.ts
(waiting for publish is useful since some issues aren't apparent when linking locally)

@dk1a dk1a added the refactor Clean up code without adding or removing features label Feb 14, 2023
@holic holic self-assigned this Feb 14, 2023
@dk1a
Copy link
Contributor Author

dk1a commented Feb 18, 2023

Looked into it some more, apparently services lacking dependencies was a minor issue.
The bigger one is that vite's optimizer doesn't support the way we use webworkers:
vitejs/vite#11943
vitejs/vite#11672
Not sure about vite internals, but since it uses esbuild this PR might make it work:
evanw/esbuild#2508

@holic
Copy link
Member

holic commented Apr 19, 2023

done in #599

@holic holic closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Clean up code without adding or removing features
Projects
None yet
Development

No branches or pull requests

2 participants