Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_to_db option to demo() #560

Open
lyie28 opened this issue Aug 8, 2024 · 4 comments
Open

Add log_to_db option to demo() #560

lyie28 opened this issue Aug 8, 2024 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lyie28
Copy link
Contributor

lyie28 commented Aug 8, 2024

The Agent log_to_db option was added to run() but not to demo() - I suggest we replicate the log_to_db option for demo()

@lyie28 lyie28 added help wanted Extra attention is needed good first issue Good for newcomers labels Aug 8, 2024
@phershbe
Copy link

I would like to work on this if you are open to a new contributor.

I am really inexperienced, but I would assume that it is the same option where you check log_to_db: bool = is_flag_true("LAVAGUE_LOG_TO_DB") and then call insert_logs() from LocalDBLogger() at the end of the function if it is true.

@lyie28
Copy link
Contributor Author

lyie28 commented Aug 13, 2024

Yes, exactly. And then just test locally that this works as expected by installing the package from local (pip install -e ./lavague-core). You can refer to the docs on the SQLite logger to see how to check the dB logs: https://docs.lavague.ai/en/latest/docs/module-guides/local-log/

@lyie28
Copy link
Contributor Author

lyie28 commented Aug 13, 2024

@phershbe feel free to ping me on Discord if you have any questions/issues while working on it - lyie7069

@phershbe
Copy link

@lyie28 I added you on Discord. I got the environment set up: I cloned the repository, got an Open AI api key, upgraded the account so that it could use GPT-4o, set up the virtual environment using Poetry, and got run() to create a db file by passing in log_to_db=True as a parameter.

I got demo() to work normally as well, but when I am trying to make changes the demo() function is crashing giving me an OSError about not finding an empty port even after I pip install -e lavague-core in order to add the changes. It is also possible that I am adding the changes with log_to_db wrongly in demo(), but I will wait to hear back from you before discussing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants