Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve to_additive warning message #20199

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve to_additive warning message #20199

wants to merge 1 commit into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Dec 23, 2024 •
edited
Loading

  • Also remove an unused simp extension from the test file, but import another low-level without many dependencies.

fixes #20181

Open in Gitpod

@fpvandoorn fpvandoorn added the t-meta Tactics, attributes or user commands label Dec 23, 2024
@github-actions GitHub Actions
Copy link

PR summary 04adc21251

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ one_eq_one
+ one_eq_one'

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@fpvandoorn fpvandoorn changed the title fix: improve to_additive error message fix: improve to_additive warning message Dec 23, 2024
Command-Master
Command-Master reviewed Dec 24, 2024
View reviewed changes
Mathlib/Tactic/ToAdditive/Frontend.lean
@@ -1183,9 +1183,11 @@ partial def applyAttributes (stx : Syntax) (rawAttrs : Array Syntax) (thisAttr s
if linter.existingAttributeWarning.get (← getOptions) then
let appliedAttrs ← getAllSimpAttrs src
if appliedAttrs.size > 0 then
let appliedAttrs := ", ".intercalate (appliedAttrs.toList.map toString)
-- Note: we're not bothering to print the correct attribute arguments.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify this comment? I'm not quite sure I understand

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone writes @[simp↓, to_additive], then the suggestion will be @[to_additive (attr := simp)], forgetting the ↓. Since this is just a suggestion, I don't think this is a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Command-Master Command-Master Command-Master left review comments

Assignees
No one assigned
Labels
t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The suggestion syntax for to_additive with another attribute does not work
2 participants
@fpvandoorn @Command-Master