Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception 'No Roles defined' is never catched #5

Open
tobiasreischmann opened this issue Aug 23, 2017 · 0 comments
Open

Exception 'No Roles defined' is never catched #5

tobiasreischmann opened this issue Aug 23, 2017 · 0 comments

Comments

@tobiasreischmann
Copy link
Member

You should apply a validation to the settings page that at least one role has to be selected.
Additionally, you should catch the exception thrown in get_roles() within check_course(), which should result in an error log and returning next without calling handle_course().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant