Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppet4 Fork of lelutin/puppet-asterisk #10

Open
diLLec opened this issue Jul 26, 2017 · 1 comment
Open

Puppet4 Fork of lelutin/puppet-asterisk #10

diLLec opened this issue Jul 26, 2017 · 1 comment

Comments

@diLLec
Copy link

diLLec commented Jul 26, 2017

Hi,

just wanted to let you know, that I've created a puppet4 fork of lelutin/puppet-asterisk and added some more functions to it.

https://forge.puppet.com/dillec/asterisk

Since the puppet4 code needed somewhat rough changes, I think that both modules need to exist separately. What are your thoughts on that?

Further, I've referenced your module in the README and used the same license. Maybe there are other publicly related details you may like to have added.

Greetings,
Michael

@lelutin
Copy link
Owner

lelutin commented Jan 15, 2018

Hi there Michael, I haven't been on top of my email for so long :(

hey this work you've done is great! I think it's about time (a bit late even maybe) that the code was renovated to puppet 4 syntax. I'm moving towards this for my fail2ban module also.

I think I should have some time next week to evaluate your fork. My idea would be to make a final release for the 1.x branch, then merge your puppet4 migration to mark the start of version 2.x. 1.x would be in maintenance mode for maybe a year more before it's abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants