You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice, if the typings would be shipped with the code. I know you decided to maintain the code by the community of definetly typed, as stated in #342 (comment) . But if it is with the package, we could easily refer them in typings, which are using them too, like in @fastify/simple-oauth2.
At fastify we ship the typings with the npm package, and test the typings with tsd. Pull Requests in fastify packages need corresponding typing changes if applicable. This way, you could ensure, that the typings are always in sync with the code.
3 years have passed since the last decision regarding this topic, so maybe you reconsider it.
Do you have a new or modified API suggestion to solve the problem?
I will provide a simple PR.
The text was updated successfully, but these errors were encountered:
Context
What problem are you trying to solve?
Follow up for #334
It would be nice, if the typings would be shipped with the code. I know you decided to maintain the code by the community of definetly typed, as stated in #342 (comment) . But if it is with the package, we could easily refer them in typings, which are using them too, like in @fastify/simple-oauth2.
See fastify/help#900 (comment)
At fastify we ship the typings with the npm package, and test the typings with
tsd
. Pull Requests in fastify packages need corresponding typing changes if applicable. This way, you could ensure, that the typings are always in sync with the code.3 years have passed since the last decision regarding this topic, so maybe you reconsider it.
Do you have a new or modified API suggestion to solve the problem?
I will provide a simple PR.
The text was updated successfully, but these errors were encountered: