Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the embed flow #23

Open
andreareginato opened this issue Aug 8, 2014 · 1 comment
Open

Improve the embed flow #23

andreareginato opened this issue Aug 8, 2014 · 1 comment

Comments

@andreareginato
Copy link
Contributor

The embedding feature is in early beta and has not been tested. Right now the release of the embedded code requires 5 to 10 minutes and needs to be automated. Here the actual flow.

  • Add the files to compile in index.html to get the final embedded js and css.
  • update dist/type-directive-ng-embed.css changing the awesome font link to a CDN. Here the mvim command to use :%s/..\/fonts\/fontawesome/http:\/\/maxcdn.bootstrapcdn.com\/font-awesome\/4.1.0\/fonts\/fontawesome/g
  • upload the type-directive-ng-embed.css, type-directive-ng-embed.js and template default.html to S3 (lelylan/directives/type) and make the folder public after the load is complete.

This whole flow needs to be automated.

@andreareginato
Copy link
Contributor Author

Another solution could be to set an iframe that points to a page where the type-directive is loaded with a specific id. In this case the only issue we need to handle is the height of the iframe, but from a first research it seems to be easy to reach. In this case all the things we do now could be removed, and the code simplified. Make some tests. Probably the right place where this should live is the future type dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant