Update and Refactor Codebase: Improve Async Usage, Package Management, and Code Quality #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the .editorconfig file to disable some diagnostics, such as CA2201 and VSTHRD200, and remove the unnecessary severity setting for dotnet_analyzer_diagnostic. This change aims to improve code quality and maintainability while reducing unwanted changes introduced by "dotnet format".
Implement Central Package Management using Directory.Packages.props and Directory.Build.targets. This centralizes package versions and analyzers across all projects. Also, add a target to run 'dotnet format' on build for Release configurations in dev environments. Update the Microsoft.SemanticKernel package reference in PRSkill.csproj to use the latest version. This change ensures compatibility and performance improvements for the project.
This commit replaces the synchronous ReadToEnd method with the asynchronous ReadToEndAsync method in CommitCommand and PRCommand classes. It also makes ConfigConstants class static and removes unnecessary newlines in ConfigCommand.
This commit updates the GitDiffStaged method in GitSkill.cs to use async-await for better performance and readability. The method now returns an awaitable Task and reads the process output asynchronously.
- Update method call to use `this` keyword for consistency - Add BOM to resource files for proper encoding - Change EnglishRobertaTokenizer class to sealed
- Remove unnecessary usings and reorder them - Simplify object initialization - Make FormatInstructionsProvider static - Minor formatting adjustments
|
/sk generate-pr-description |
github-actions
bot
changed the title
|
Generate PR Description: succeeded ✅ |
lemillermicrosoft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request includes a series of updates and refactoring efforts across the codebase, focusing on improving async usage, introducing central package management, updating package references, and enhancing code quality and readability.
Changes
Powered by Microsoft Semantic Kernel