Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit SVG costume subpixel positioninging for non-integer viewboxes #132

Open
towerofnix opened this issue Jul 18, 2022 · 0 comments
Open

Comments

@towerofnix
Copy link
Member

towerofnix commented Jul 18, 2022

Issue corresponds to this code to-do:

// TODO: handle proper subpixel positioning when SVG viewbox has non-integer coordinates
// This will require rethinking costume + project loading probably
_createMipmap(mipLevel) {

Follow-up on #119 (comment):

@adroitwhiz wrote:
I wrote up a summary of this a while back, over in scratchfoundation/scratch-render#550. There's an associated PR that fixes it in scratchfoundation/scratch-render#594.

There's a good deal of discussion in those links. This is a bigger issue to address later which, as the to-do notes, may require or be easier to approach with costume/project preloading (#133) instead of generating costumes/skins/etc "on demand" (during execution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant