Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking Codacy suggestions into account #16 #30

Closed

Conversation

rajitha1998
Copy link
Member

Fixes #16

Proposed Changes

  • This PR adds some Codacy suggestions in order to improve code quality

@rajitha1998 rajitha1998 marked this pull request as ready for review January 6, 2020 19:48
Copy link
Member

@rajikaimal rajikaimal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajitha1998 did you use Prettier to format?

@rajitha1998
Copy link
Member Author

No, I haven't use prettier to format. Shall I format the code using Prettier ? @rajikaimal

  • By the way some suggestions under the category of Error Prone which I assume that the console logs were added to display the output of this example or to display an error message. So I didn't remove them.
    E.g. -
    Capture

  • I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored const ncConfig = require(path.join(process.cwd(), ".nc.config"));
    Capture

@rajikaimal
Copy link
Member

@rajitha1998 Yes, use Prettier to format all the files.

@rajitha1998
Copy link
Member Author

@rajikaimal , I formatted the code using prettier. Since codacy was showing me the below suggestion I had to add a prettier rule for that in the .prettierrc file as { "arrowParens": "always" }

// Bad 
a => {
}
// Good 
(a) => {
}

Related links -

@rajikaimal
Copy link
Member

@rajitha1998 Can you resolve the conflict. LGTM

@rajitha1998
Copy link
Member Author

@rajitha1998 Can you resolve the conflict. LGTM

sure

@rajitha1998
Copy link
Member Author

Merge conflicts fixed @rajikaimal ☺️

@rajitha1998 rajitha1998 closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codacy changes
2 participants